spring-cloud-commons icon indicating copy to clipboard operation
spring-cloud-commons copied to clipboard

support logger group when refresh by the /refresh endpoint

Open xfrogcn opened this issue 3 years ago • 3 comments

The current implement of LoggingRebinder , when refreshed by the /refresh endpoint, only changes the level of specific loggers and does not yet support changes the level of logger groups. This pull request adds support for logger groups in LoggingRebinder, including:

  1. Modify the log level of the logger group
  2. Dynamically add, modify, delete logger groups or loggers in groups

xfrogcn avatar Apr 30 '21 09:04 xfrogcn

@xfrogcn Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster avatar Apr 30 '21 09:04 pivotal-issuemaster

@xfrogcn Thank you for signing the Contributor License Agreement!

pivotal-issuemaster avatar Apr 30 '21 09:04 pivotal-issuemaster

The constructor change is a breaking change, meaning this wouldn't be able to be included until next year. It seems like some of the changes go beyond groups setDefaultLogLevel(). Can you describe what those do?

spencergibb avatar Jun 03 '21 16:06 spencergibb