Fixed bug with DefaultServiceInstance: getScheme() was not implemented

[dagerber]

This fixes the problem, that a https URI could not be overriden in Unit tests with http (avoiding certificate problems on the build server)

[OlgaMaciaszek]

Fixes gh-823.

[OlgaMaciaszek]

@dagerber since we are doing a release today, I'm going to cherry-pick your commits, add the changes from the comments and merge it already.

[dagerber]

Hi Olga I just started fixing, would be done in 30min Do you want to wait? Daniel

Am Di., 16. März 2021 um 16:51 Uhr schrieb Olga Maciaszek-Sharma < @.***>:

@dagerber https://github.com/dagerber since we are doing a release today, I'm going to cherry-pick your commits, add the changes from the comments and merge it already.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/spring-cloud/spring-cloud-commons/pull/926#issuecomment-800381327, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEEOD2NMSB5UTRNZDEECNLTD547PANCNFSM4ZB4DMDA .

[OlgaMaciaszek]

Ok, @dagerber. Please change it then and submit against 2.2.x.

[dagerber]

Hi Olga Please cherry-pick as you suggested before. It takes too much time to fix against 2.2.x Thanks! Daniel

Am Di., 16. März 2021 um 16:59 Uhr schrieb Olga Maciaszek-Sharma < @.***>:

Ok, @dagerber https://github.com/dagerber. Please change it then and submit against 2.2.x.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/spring-cloud/spring-cloud-commons/pull/926#issuecomment-800388491, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEEOD7PDYFKN3BY2TXHSOTTD557DANCNFSM4ZB4DMDA .

[spencergibb]

@dagerber you needed to do a force push as now there are unrelated commits here.

[dagerber]

Sorry about that. I reset --hard to the commit before the unwanted merge and push forced.... Hope it is OK now

Am Di., 16. März 2021 um 17:50 Uhr schrieb Spencer Gibb < @.***>:

@dagerber https://github.com/dagerber you needed to do a force push as now there are unrelated commits here.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/spring-cloud/spring-cloud-commons/pull/926#issuecomment-800432243, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEEOD64QEZPPQ5T44F44KTTD6D55ANCNFSM4ZB4DMDA .

[spencergibb]

Indeed, thanks, that's better.

[spencergibb]

cherry picked to 2.2.x and merged forward via 4269bb38034e07c1a96a3a98ef391ea853fb9ef5

[spencergibb]

reverted. see https://github.com/spring-cloud/spring-cloud-commons/issues/823#issuecomment-800585374