spring-cloud-commons icon indicating copy to clipboard operation
spring-cloud-commons copied to clipboard

Common discovery properties

Open spencergibb opened this issue 4 years ago • 1 comments

Eureka, consul and zookeeper have very similar properties for things like hostname, ipaddress, port, preferIpAddress, service or app name, instance id, metadata, etc...

It may be worth having a common set of properties under spring.cloud.discovery and then each can have custom properties.

It may be that this is just an abstract class and downstream projects use spring.cloud.<project>.discovery as namespace.

Maybe migrate netflix from eureka.instance to spring.cloud.netflix.discovery.

spencergibb avatar Apr 27 '20 18:04 spencergibb

I like it! The binding properties in SC Stream follow the same concept. It might be more user friendly to use spring.cloud.discovery.default and spring.cloud.discovery.<project> so the properties remain in the "discovery" namespace rather than the project specific namespace which, for example, makes it easier to group in yaml.

TYsewyn avatar Apr 27 '20 18:04 TYsewyn