spring-cloud-commons icon indicating copy to clipboard operation
spring-cloud-commons copied to clipboard

SSLContextFactory should allow for no key store

Open freafrea opened this issue 3 years ago • 2 comments

I am using 3.1.4. My spring cloud config server has a self signed cert. I did not want to add its certificate to java trust store, so I wanted to use TlsProperties to provide the trust store. I can't do that without providing the keystore.

Currently the trust store is optional, I think the keystore needs to be optional too, as not always we need to use ssl client verification.

I can made a PR with the change, but I am not sure if removing this requirement in a straightforward way is OK for you.

freafrea avatar Dec 21 '22 09:12 freafrea

PR is welcome

ryanjbaxter avatar Jan 04 '23 16:01 ryanjbaxter

I've added the PR

freafrea avatar Jan 08 '23 20:01 freafrea