spring-cloud-commons icon indicating copy to clipboard operation
spring-cloud-commons copied to clipboard

ReactiveDiscoveryClient.probe is practically a no-op

Open trajano opened this issue 2 years ago • 0 comments

Describe the bug

the .probe method is defined as

default void probe() {
    getServices();
}

and getServices() also returns a Flux, since Flux don't do anything without a subscribe this is practically a no-op

Perhaps the interface should be defined as returning Mono<Void> as in

default Mono<Void> probe() {
    return getServices()
      .then();
}

trajano avatar May 07 '22 23:05 trajano