spring-cloud-aws icon indicating copy to clipboard operation
spring-cloud-aws copied to clipboard

QueueMessageChannel.receive() implementation doesn't align with PollableChannel 's definition

Open jorgenota opened this issue 3 years ago • 0 comments

Type: Bug

Component:

SQS

Describe the bug

  • According to javadoc of PollableChannel, MessageChannel.INDEFINITE_TIMEOUT should be used to represent indefinite timeout (instead of 0).
  • The timeout parameter of PollableChannel.receive() method represents the timeout in milliseconds (so it should be transformed into seconds when building the ReceiveMessageRequest).

This PR betters shows the suggested fix: #769

jorgenota avatar Apr 03 '21 10:04 jorgenota