locks icon indicating copy to clipboard operation
locks copied to clipboard

some refactorings and prevent possible nullpointer exception

Open AlicanAkkus opened this issue 5 years ago • 8 comments

AlicanAkkus avatar May 22 '19 06:05 AlicanAkkus

@AlicanAkkus Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster avatar May 22 '19 06:05 pivotal-issuemaster

@AlicanAkkus Thank you for signing the Contributor License Agreement!

pivotal-issuemaster avatar May 22 '19 06:05 pivotal-issuemaster

@spencergibb hi, can you review pr and can you share your opinions with me? thanks.

AlicanAkkus avatar May 26 '19 17:05 AlicanAkkus

@dsyer would be the one to review.

spencergibb avatar May 26 '19 18:05 spencergibb

@dsyer would be the one to review.

I'm waiting for your review :)

AlicanAkkus avatar Jun 01 '19 13:06 AlicanAkkus

LGTM. Lots of whitespace changes though. Maybe we should add the spring-format plugin.

dsyer avatar Jun 01 '19 14:06 dsyer

LGTM. Lots of whitespace changes though. Maybe we should add the spring-format plugin.

I've added the format plugin and did reformat.

AlicanAkkus avatar Jun 01 '19 21:06 AlicanAkkus

@dsyer @spencergibb hi, can you review again, please?

AlicanAkkus avatar Jun 07 '19 06:06 AlicanAkkus