kaffe icon indicating copy to clipboard operation
kaffe copied to clipboard

Add start_link/1 function to GroupMemberSupervisor

Open objectuser opened this issue 6 years ago • 3 comments

This function is in support for the new supervisor child specs supported in Elixir. This allows just the module to be provided as a child to the parent supervisor.

  def start(_type, _args) do

    children = [
      Kaffe.GroupMemberSupervisor
    ]

    opts = [strategy: :one_for_all, name: MyApp.Supervisor]
    Supervisor.start_link(children, opts)
  end

objectuser avatar May 09 '18 13:05 objectuser

@objectuser - Is this something that's still worth merging in? Are there any risks with backwards compatibility?

dtykocki avatar Aug 31 '19 19:08 dtykocki

@dtykocki I'm not sure why I didn't merge this in. I don't think there are any compatibility issues because it's additive. I do think the extra changes should be removed.

objectuser avatar Sep 02 '19 16:09 objectuser

That change can be merged to be updated with the Supervisor child specs?

vittoriabitton avatar Jul 28 '20 17:07 vittoriabitton