spree_auth_devise icon indicating copy to clipboard operation
spree_auth_devise copied to clipboard

Upgrading to the new version with Spree 3.1

Open gaqzi opened this issue 8 years ago • 3 comments

When upgrading to the 3.1 stable branch we discovered that the extension now has some javascript parts. It took a while to figure that out as there's no changelog and no upgrade instructions to start including the javascript.

As well we discovered that when you have an extension that has modified the UI and uses the hooks of the old rendered-in-place links then you'll also have to enable the javascript in the extension's dummy app. While straightforward it took a bit of exploring to figure out. In case it's useful for someone else:

task :test_app do
  # …
  File.open('vendor/assets/javascripts/spree/frontend/all.js', 'a') { |f| f.write "//= require spree/frontend/spree_auth\n" }
  puts `bundle exec rake assets:precompile`
end

gaqzi avatar Jul 19 '16 08:07 gaqzi

Thanks @gaqzi for pointing this out - docs needs to be more precise on this.

damianlegawiec avatar Jul 19 '16 09:07 damianlegawiec

@damianlegawiec just out of curiosity, what is the reason for having it as Javascript? I have my theory but would be nice to know :)

gaqzi avatar Jul 19 '16 09:07 gaqzi

@gaqzi ease of implementing full page caching and keeping it the same as cart preview :) Frontend actually isn't our top priority (API & Admin Panel are) as it's the part that is most frequently swapped entirely for something custom (and that's a good thing).

damianlegawiec avatar Jul 19 '16 09:07 damianlegawiec