spree icon indicating copy to clipboard operation
spree copied to clipboard

Change after_save hook to after_update, because on create, this updat…

Open mrbrdo opened this issue 3 years ago • 1 comments

…e is not necessary. Additionally, these updates on create cause issues with translations (such as spree_globalize or spree_mobility)

As said in commit message, these hooks should be after_update, as they serve no purpose on create. Also, even if they should technically work, they break spree_globalize or spree_mobility translations in a very edge-casey way. Also see https://github.com/mrbrdo/spree_mobility/issues/6

Besides, all it does on create is make a bunch of unnecessary queries and slow things down.

mrbrdo avatar May 26 '22 23:05 mrbrdo

Changes preview:

Legend:

👀 Review pull request on Viezly

viezly[bot] avatar May 26 '22 23:05 viezly[bot]

@rafalcymerys please merge, quite obvious fix.

mrbrdo avatar Oct 25 '22 21:10 mrbrdo