spree_store_credit_payment_method
spree_store_credit_payment_method copied to clipboard
spree-contrib
Don't create gift cards until the order has been completed
Gift cards are being created after an order transitions to the confirm state, which causes issues if the order bounces back to an earlier state and the line item for the gift card is modified.
For instance, if a user adds 2 gift cards to their cart, reaches the confirm state, then goes back and removes one of the gift cards, they'll still have 2 valid gift cards associated with the line item.
finalize! seems like a much better place for this, as we can be assured that the order has been completed.
I also bumped spree in the gemspec. I had issues bundling and it looks like the master branch of Spree is now up to rc3, which fixed the issue.
@plongyear if you have issues bundling because of prerelease .beta .rc etc... it probably means you need to update to latest version of bundler. That used to annoy the hell out of me.
Definitely better to not create the cards until order transitions to complete, which fires finalize so that's fine.
This fixes part of issue #19. I think the addition of the store credit payments could happen before the transition to the payment step, that way you could also get fully covered orders to move beyond the payment phase without requiring an additional zero'd credit card payment.
@JDutil thanks for the tip. I did update bundler but I believe we still need to bump spree to rc3. It looks like SPREE_VERSION is no longer set to 2.4.0.beta on master in spree.
As for creating the cards on completion, are you suggesting that we do this as a state machine transition rather than overwriting finalize!? I'd be happy to update this if so.
If you did it as it's own transition you don't need to worry about finalize! ever changing. Granted it's unlikely, but just a way to avoid maintenance.