spree_product_zoom
spree_product_zoom copied to clipboard
spree-contrib
Update install_generator.rb
I boiled it down to changing this one file. I tested back and forth, an realized that I did not need to create a separate CSS file or bring over the images. All that was needed was to change the files in assets instead of vendor/assets. Hope you agree. Kind regards.
I don't think this is correct. Your spree assets should be under vendor/assets not app/assets, and this may just be an issue with upgrading from an older version of spree without moving them to vendor from app. Did you try installing this in a fresh 2.4 store or did you upgrade to 2.4 then try to install the extension?
You are changing the manifest files. Changing them in vendor/assets does not seem to work. I started out in spree 2.3 and shortly thereafter upgraded to version 2.4. I introduced spree_product_zoom after upgrading to 2.4.
Kruby Thomas K. Schmidt +45 40 19 68 81
Den 26/11/2014 kl. 07.17 skrev Jeff Dutil [email protected]:
I don't think this is correct. Your spree assets should be under vendor/assets not app/assets, and this may just be an issue with upgrading from an older version of spree without moving them to vendor from app. Did you try installing this in a fresh 2.4 store or did you upgrade to 2.4 then try to install the extension?
— Reply to this email directly or view it on GitHub.
Where in your application do the manifest files exist? They should be under vendor/assets not assets.
Hi Jeff,
They exist in both places.
Venlig hilsen / Kind regards Thomas K. Schmidt
Kruby +45 40 19 68 81 www.kruby.dk
Den 26/11/2014 kl. 17.29 skrev Jeff Dutil [email protected]:
Where in your application do the manifest files exist? They should be under vendor/assets not assets.
— Reply to this email directly or view it on GitHub.
I believe this is some sort of issue with your application itself, and not a required change in this extension. It appears to be that your assets are not within the expected locations. Can you reproduce the problem on a fresh 2.4 store?
Hi Jeff,
I will try that and get back to you. I thought this problem had to do with this that I found in the Rails guide under Asset Pipeline just before section 2.2.1:
If you are upgrading from Rails 3, please take into account that assets under lib/assetsor vendor/assets are available for inclusion via the application manifests but no longer part of the precompile array. See Precompiling Assets for guidance.
Venlig hilsen / Kind regards Thomas K. Schmidt
Kruby +45 40 19 68 81
Den 26/11/2014 kl. 21.17 skrev Jeff Dutil [email protected]:
I believe this is some sort of issue with your application itself, and not a required change in this extension. It appears to be that your assets are not within the expected locations. Can you reproduce the problem on a fresh 2.4 store?
— Reply to this email directly or view it on GitHub.
Hi Jeff,
Just another thought. I have not done anything as described here to my application.rb file:
Besides the standard assets/* paths, additional (fully qualified) paths can be added to the pipeline in config/application.rb. For example:
config.assets.paths << Rails.root.join("lib", "videoplayer", "flash") Paths are traversed in the order they occur in the search path. By default, this means the files in app/assets take precedence, and will mask corresponding paths in lib and vendor.
Venlig hilsen / Kind regards Thomas K. Schmidt
Kruby +45 40 19 68 81
Den 26/11/2014 kl. 21.17 skrev Jeff Dutil [email protected]:
I believe this is some sort of issue with your application itself, and not a required change in this extension. It appears to be that your assets are not within the expected locations. Can you reproduce the problem on a fresh 2.4 store?
— Reply to this email directly or view it on GitHub.