spree_drop_ship icon indicating copy to clipboard operation
spree_drop_ship copied to clipboard

Doesn't work with Rails 5 and Spree 3.2.0

Open priom opened this issue 8 years ago • 12 comments

priom avatar Feb 26 '17 07:02 priom

I am currently using spree to create a marketplace app and It will be really nice if this could be upgraded to work with Rails 5 and Spree 3.2.0. Is there a possibility for that in coming weeks or months? @JDutil

mayordwells avatar Apr 14 '17 13:04 mayordwells

+1

bradpurchase avatar Apr 25 '17 13:04 bradpurchase

+1 Rails - 5.1 Spree - 3.3 and above

haxplorer avatar Mar 05 '18 09:03 haxplorer

Hi. I've made some modifications in the gem to work with rails 5.1 and spree 3.4.4. You could find them in https://github.com/MateoLa/spree_drop_ship/releases v1-0-0. Let me know if it is useful for someone.

MateoLa avatar Mar 16 '18 19:03 MateoLa

@MateoLa How do I import the upgraded to gem into my application?

dbbooke avatar Apr 03 '18 20:04 dbbooke

@dbbooke We did it by pointing to @MateoLa's fork in our Gemfile, like this:

gem 'spree_drop_ship', git: 'https://github.com/MateoLa/spree_drop_ship'

bradpurchase avatar Apr 03 '18 20:04 bradpurchase

I don't think you guys know how much the old gem provided by Spree-contrib has been bugging me because it didn't work lol. Appreciate it guys

dbbooke avatar Apr 03 '18 20:04 dbbooke

@dbbooke yeah, our Rails 5 upgrade has been delayed for months mostly because we didn't have the time to do this update ourselves, so really appreciate it @MateoLa!

bradpurchase avatar Apr 03 '18 20:04 bradpurchase

One more question, I am getting this error after migrating @MateoLa WARN DurableDecorator: Spree::StockLocation#propagate_variant decoration uses an invalid SHA. The original method definition could have been tampered with! WARN DurableDecorator: Expected SHA was 68fd322da48facbdbf567a2391c2495d04c3c8bc but the provided SHA is f35b0d8a811311d4886d53024a9aa34e3aa5f8cb

should everything still be find?

dbbooke avatar Apr 03 '18 20:04 dbbooke

Also, the Doc_ship gem is required for spree_marketplace gem. Is anyone else having a hard time with that gem with Rails 5?

dbbooke avatar Apr 03 '18 20:04 dbbooke

Hi Darren and Brand.

I don't know if I'm going to need to work with spree-marketplace in the near future. I let you know if I do it. Regarding the SHA key error, replece the key in the correct place and the error will go away.

I also have litle free time because I trying to adapt my site to go online.

I really appreciate your feedback.

Thanks, Mateo.

2018-04-03 17:38 GMT-03:00 Darren Booker [email protected]:

Also, the Doc_ship gem is required for spree_marketplace gem. Is anyone else having a hard time with that gem with Rails 5?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/spree-contrib/spree_drop_ship/issues/80#issuecomment-378391044, or mute the thread https://github.com/notifications/unsubscribe-auth/AMmXWaPdmDOSB-1EbKIxZJ2plmNpshsRks5tk923gaJpZM4MMSPq .

MateoLa avatar Apr 06 '18 16:04 MateoLa

Why is contrib's latest version only for spree 2.2 When are they gonna get caught up?

mices avatar Jul 16 '18 19:07 mices