spree-product-assembly
spree-product-assembly copied to clipboard
on 2-0 you are able to add stock to products with parts
Stock used to be calculated based on parts on 1-3
@huoxito is this ok for 2.0? Or just something that hasn't been upgraded, I was thinking of adding a list with the breakdown of parts and stock per location
hmm, that view is already there so maybe just remove the form
hey @geermc4 sorry but I don't understand the issue. Stock for parts is still calculated, for example you shouldn't be able to add a bundle to cart if any of the parts doesn't have enough stock.
Could you describe steps that indicates the extension doesn't behave the way you expected? thanks
I mean in the admin, if you go to stock management for a product with parts, it still allows you to set what you have on each location, that field used to not show.
https://github.com/spree/spree/blob/master/backend/app/views/spree/admin/products/stock.html.erb#L9 is what i'm saying needs to change for products with parts, maybe ... a) hide that form, and b) use something other than count_on_hand for https://github.com/spree/spree/blob/master/backend/app/views/spree/admin/products/stock.html.erb#L57
Ah right I think we could
- hide the stock management form for product with parts and instead display the stock count for each part
- hide the variants tab for products with parts
I believe that fixes the issue
I just wonder what happened with this issue, isn't fixed up yet? this conversation was 8 months ago.
Well, I guess not, I'm on it!