spray-json icon indicating copy to clipboard operation
spray-json copied to clipboard

Building with scala 3

Open raboof opened this issue 4 years ago • 8 comments

Fixes #341

raboof avatar Jul 22 '21 08:07 raboof

I added a fix for the self-type issue but the tests don't compile cleanly any more, mostly because the new version of specs is not syntax compatible with the old.

jrudolph avatar Jul 22 '21 10:07 jrudolph

I added a fix for the self-type issue

Nice!

but the tests don't compile cleanly any more, mostly because the new version of specs is not syntax compatible with the old.

Ah, we can use a cross-dependency for the tests https://github.com/etorreborre/specs2/issues/848

raboof avatar Jul 22 '21 10:07 raboof

Cool, I fixed all the compilation issues but now it seems that

  • some printing facility changed, now escaping unicode characters
  • ProductFormats don't work any more, probably because Scala compilation changed the way fields are encoded

jrudolph avatar Jul 22 '21 10:07 jrudolph

ProductFormats don't work any more, probably because Scala compilation changed the way fields are encoded

Ultimately, we would want to use derivation in Scala 3, but I guess it would be nice to support it in a simpler way until then?

jrudolph avatar Jul 22 '21 10:07 jrudolph

Fixed the remaining issues, was pretty trivial after all.

jrudolph avatar Sep 09 '21 09:09 jrudolph

/cc @jrudolph this might now be good to go?

raboof avatar Nov 16 '21 12:11 raboof

Is this dead?

hughsimpson avatar Jul 14 '23 21:07 hughsimpson

With #345 merged and https://repo1.maven.org/maven2/io/spray/spray-json_3/1.3.6/ published this PR isn't so urgent anymore - the project is in 'maintainance mode' (https://github.com/spray/spray-json#maintanance-mode) and perhaps there won't even really be a need for a 1.4.x release

raboof avatar Jul 25 '23 08:07 raboof