Simon Sprankel

Results 262 comments of Simon Sprankel

I think we should have this feature in the core!

Really? Oh boy, I am getting old. Sorry for that. Thanks!

I do not need this feature, but I am fine with merging it :)

I understand your issue and I think it would be much better if the shipping taxes would be included in the 7% / 19% taxes, but this is how Magento...

@nige-one serious? If you return `null`, the shipping tax will be included into the 7% / 19% tax amounts!?

If this works reliably in all versions, we should implement a configuration option for it and should default it to "yes". In theory, it is a requirement in Germany to...

@nige-one will you implement this or should I try to do it?

If your idea/fix results in the situation that taxes are splitted by tax rate, I think it is great! Since we already rewrite `Mage_Tax_Model_Sales_Pdf_Grandtotal`, we can simply add it there....

Having the SKU and the quantity next to each other can also be tricky if you have numeric SKUs. For the invoice, the column order is completely customisable. I vote...

Just fixed many issues reported by [MEQP1](https://github.com/magento/marketplace-eqp): https://github.com/firegento/firegento-pdf/commit/8842d86b7c1be96d6684c8db776259144a2714c5