Simon Sprankel comments

Results 262 comments of


                                            Simon Sprankel

Make Logging Optional / Reduce Logging

Any update?

disabled domain validation to allow mail addresses from new TLDs

Could you please merge this?

disabled domain validation to allow mail addresses from new TLDs

Could you please merge this?

disabled domain validation to allow mail addresses from new TLDs

@agrohs @rsbowers mind merging this?

Do Not Ignore Test Folder

Thanks @jissereitsma! Should we keep this open and also implement a `require` vs `require-dev` (if dependency is only used in `Test` directory) separation? Or don't you want to implement that...

Do Not Ignore Test Folder

Thanks! Not sure how to handle this, because I do not know the details tbh. I just would like to propose the `require` vs `require-dev` separation again :-)

Check Use Statements As Well

Do I read this correctly as "that is a good idea and should be implemented"? :)

Check Use Statements As Well

I do not think so. If you use the imported class in the constructor, it works. However, if you do *not* use the imported class in the constructor, but somewhere...

Does it push ecommerce Tags / events?

Here is a basic start: https://github.com/yireo/Yireo_GoogleTagManager2/pull/90

Dependency possible not needed.

That was not too hard to fix... ;-)