gendarme icon indicating copy to clipboard operation
gendarme copied to clipboard

DisposableFieldsShouldBeDisposedRule gives false positives on generic classes

Open skolima opened this issue 12 years ago • 0 comments

Code sample ( https://gist.github.com/3736634 ):

    public class GenericClassWithDisposableField<T> : IDisposable
    {
        private IDisposable dataTable;
        public void Dispose()
        {
            dataTable.Dispose();
        }
    }

    [Test]
    public void GenericClass_Disposal()
    {
        AssertRuleSuccess<GenericClassWithDisposableField<Object>>();
    }

This does report dataTable as not being disposed. Removing generic parameter from the parent class makes the test pass.

skolima avatar Sep 17 '12 10:09 skolima