Sebastien Pouliot

Results 170 comments of Sebastien Pouliot

xtro rule and some (partial) updates to bindings are merged with https://github.com/xamarin/xamarin-macios/pull/8335

> If this is something that you were planning to address @cosminstirbu short answer: yes, that's the step "Fix the bindings" in the issue's description. **Long answer** Xamarin.iOS/Mac added nullability...

Look at the `.ignore` files that my PR updated https://github.com/xamarin/xamarin-macios/pull/8335/files?file-filters%5B%5D=.ignore There's a `common` file (prefix) and OS specific files for each framework. If a file does not exists then it's...

`NSString.CreateNative` (and `FreeNative`) should be used, it's cheaper since there won't be a managed allocation - which also means the GC can't do anything.

Looks like it's not _really_ generated code. ```csharp [Wrap ("NextEvent ((NSEventMask) (ulong) mask, expiration, (NSString) mode, deqFlag)", IsVirtual = true), Protected] ```

@rolfbjarne found other generated cases ? IIRC we dispose of all locally created `NSObject` instances which should make then unavailable to collection during the native call. The ones on the...

Might (or not) be related but https://github.com/xamarin/xamarin-macios/commit/f21f563eb3236912ba0d57712ebf92c78e92f29e shows > 14 tests failed, 136 tests passed. and when expanded we can see 14 of them Clicking on the azdo link https://dev.azure.com/devdiv/DevDiv/_build/index?buildId=3547058&view=ms.vss-test-web.test-result-details...

another mismatch (tvOS) 6 on GitHub/html report 4 on azdo https://github.com/xamarin/xamarin-macios/pull/7795#commitcomment-37823330

another mismatch ddfun 19 failures on GitHub 3 failures on AzDO https://github.com/xamarin/xamarin-macios/commit/723ec1857c0bf3492d9a21899553e28ed67a5164

With ILLink (dotnet) the types mentioned (as `Type`) inside an attribute are marked. This makes it impossible to pass this test. ``` [ProtocolMember (IsRequired = false, IsProperty = false, IsStatic...