spotify_to_tidal icon indicating copy to clipboard operation
spotify_to_tidal copied to clipboard

Various improvements

Open joshrmcdaniel opened this issue 1 year ago • 5 comments

This is currently a WIP, theres a couple of things TODO:

  • hide 429 log message
  • improve searching further
  • update docs
  • remove redundant functions

  New features:

  • Caching is now a singleton, all songs retrieved in all playlists will be cached during run.
  • Significantly improved runtime
  • Only run process map on results not cached
  • CLI package
  • tidalapi to 0.7.2
  • Add logging
  • Searching now uses casefold instead of lower, to better check title equality
  • Searching now uses all spotify artists (if multiple artists specified in Spotify)
  • Refactor
  • Type hint
  • Most YAML file attributes can be specified on the CLI
  • Various other improvements

joshrmcdaniel avatar Jan 15 '24 23:01 joshrmcdaniel

Hey @joshrmcdaniel thanks for the PR it looks good but it's quite a lot of changes for me to review and I'm not really able to put much time into this project. Would you be interested in taking over maintenance of this project?

timrae avatar Apr 28 '24 10:04 timrae

heya @joshrmcdaniel, i made some ajustments which may be useful for you to look at, namely: sync.txt

clearing the teriminl after each playlist

  • print("\033[2J\033[H", end="", flush=True)

"fixing" the ratelimit

  • tidal_tracks = call_async_with_progress(tidal_search, spotify_tracks, task_description, config.get('subprocesses', 10), tidal_session=tidal_session)

if you have discord, that would be a lot better to collaborate on this :)

RobinHirst11 avatar Apr 29 '24 11:04 RobinHirst11

I can take a look at doing fixes this weekend @RobinHirst11

I don't mind taking over in regards to maintenance either @timrae

joshrmcdaniel avatar May 06 '24 23:05 joshrmcdaniel

Would be great to incorporate some of these changes if you can pull them out into smaller PRs once #43 is merged

timrae avatar May 27 '24 10:05 timrae

@joshrmcdaniel Please email me if you're still interested in helping out with maintenance. You can find my email in the git history.

timrae avatar Jun 12 '24 03:06 timrae