reactochart icon indicating copy to clipboard operation
reactochart copied to clipboard

resolvers in `resolveXYScale` should recursively traverse `children` tree

Open dandelany opened this issue 8 years ago • 1 comments

The new code in 0.2.1 is improving but has a significant regression - All of the resolvers in resolveXYScales used to recursively check the component's children to find the necessary props. However @thehindenburg 's new mapOverChildren, while being a nicer abstraction, does not do recursion - it only maps over an element's direct children.

Recursion is necessary IMHO because we want to support the use case of the user having intermediate layer components between XYPlot and their charts, eg.:

<XYPlot>
  <CustomChartWrapper>
    <LineChart />
    <AreaChart />
    <BarChart />
  </CustomChartWrapper>
</XYPlot>

Without recursion, this would never try to resolve anything on the actual chart components, it would stop at CustomChartWrapper. We should improve the general resolution functions in resolveXYScales to handle this case

dandelany avatar Jan 06 '17 17:01 dandelany

Related to #35

dandelany avatar Jan 06 '17 17:01 dandelany