luigi icon indicating copy to clipboard operation
luigi copied to clipboard

Remove `pkg_resources`

Open aliavni opened this issue 8 months ago • 5 comments

Description

luigid fails to start in Python 3:12 due to missing setuptools.

Motivation and Context

Fix https://github.com/spotify/luigi/issues/3350

Have you tested this? If so, how?

Yes. I installed this code on a fresh virtual environment with the following:

pip install https://github.com/aliavni/luigi/archive/add-setuptools.zip

And the issue is resolved. lugid starts without issues

aliavni avatar May 15 '25 13:05 aliavni

@dlstadther I think this PR looks good. Can you please take a look

aliavni avatar May 15 '25 13:05 aliavni

Great job! As alternative solution, we can replace deprecated API calls with importlib calls as suggested here

pkg_resources is used in 2 places only

EugeneYushin avatar May 15 '25 14:05 EugeneYushin

@RRap0so , could we update merge rules to not require that codecov/* checks be passing? I've seen inconsistencies in their reliability.

dlstadther avatar May 17 '25 19:05 dlstadther

Hi team, do you plan on merging this PR? I am using luigi with python 3.13. Currently I am using pip to install setuptools in order to get luigid to start. I see this warning:

The pkg_resources package is slated for removal as early as 2025-11-30

So I am wondering if can expect this PR to be merged or if I should roll back to an earlier python (or setuptools) version.

Thank you.

alexeiverbny avatar Nov 07 '25 15:11 alexeiverbny

@alexeiverbny This project has fallen off my radar. I see that this PR's last CI failed tests. I'm not sure what has happened since then, but it appears that I no longer have permissions to rerun the Github Actions pipelines like i used to.

The latest changes LGTM, i'd just like to see the test suite succeed.

dlstadther avatar Nov 08 '25 02:11 dlstadther