heroic icon indicating copy to clipboard operation
heroic copied to clipboard

README.md's link to ClusterIT.java is busted

Open sming opened this issue 4 years ago • 2 comments

See https://github.com/spotify/heroic/blob/master/rpc/jvm/README.md :

For an example of this, see the ClusterIT test suite.

The link is to https://github.com/spotify/heroic/blob/master/heroic-dist/src/test/java/com/spotify/heroic/ClusterIT.java which is nonexistant.

sming avatar Jun 30 '20 18:06 sming

@sjoeboo, any idea which file it should point to? perhaps https://github.com/spotify/heroic/blob/master/heroic-dist/src/test/java/com/spotify/heroic/AbstractLocalClusterIT.java ?

sming avatar Jun 30 '20 18:06 sming

Yup should be the latter, I made a PR: https://github.com/spotify/heroic/pull/672/

lmuhlha avatar Jun 30 '20 22:06 lmuhlha