folsom icon indicating copy to clipboard operation
folsom copied to clipboard

Add outstanding-request metrics per connected host

Open spkrka opened this issue 5 years ago • 4 comments

spkrka avatar Jul 10 '20 12:07 spkrka

@spkrka SemanticFolsomMetricsTest::testRegisterOutstandingRequestsGauge is failing with this change. Here's a gist to fix and improve that test: https://gist.github.com/amirhadadi/6e4580c7e91887e53f0993d30e619674

amirhadadi avatar Jul 29 '20 22:07 amirhadadi

@spkrka did you have a chance to review my suggested fix?

amirhadadi avatar Sep 24 '20 05:09 amirhadadi

No, I am still not sure if this change even makes sense on a high level.

spkrka avatar Sep 24 '20 07:09 spkrka

@spkrka the motivation is to have metrics that will allow identifying misbehaving memcached nodes. There's also another related issue - the disconnect reason in DefaultRawMemcacheClient does not contain the offending node, which can be very helpful in identifying misbehaving nodes.

amirhadadi avatar Sep 24 '20 08:09 amirhadadi