fmt-maven-plugin icon indicating copy to clipboard operation
fmt-maven-plugin copied to clipboard

Published 20 hours ago • verified publisher icon spotify

Upgrade Google Java Format 1.24.0 -> 1.25.2

Open vladimirconev opened this issue 11 months ago • 3 comments

Upgrade to latest Google Java Formatter v1.25.2 (https://github.com/google/google-java-format/releases/tag/v1.25.2)

vladimirconev avatar Dec 14 '24 10:12 vladimirconev

Unfortunately this won't work without further changes; see #195. I have yet to find time for a closer look. Perhaps you're up for that, @vladimirconev?

Stephan202 avatar Dec 14 '24 11:12 Stephan202

Using 11, upon upgrade to google formatter 1.25.2 there are some compilation issues. Changing Maven Runner to Java 17 and running 'mvn clean verify' builds successfully ([ERROR] The following builds was skipped: [ERROR] * fork_never_beforejdk16\pom.xml due to JRE version).

vladimirconev avatar Dec 14 '24 12:12 vladimirconev

Based on past activity: @knifeofdreams or @andreasfolkesson are you okay with raising the build baseline to JDK 17 (required by google/google-java-format#1159), without modifying the build to cover that one JDK 11 test case? If so, it'd be great to have a release with this change and a bump to version 1.26.0.

(Other past maintainers of this repository include @caesar-ralf, @bryanlb and @klaraward, but based on their profile they no longer work at Spotify.)

Stephan202 avatar Mar 29 '25 15:03 Stephan202