flink-on-k8s-operator icon indicating copy to clipboard operation
flink-on-k8s-operator copied to clipboard

Rework Helm charts

Open regadas opened this issue 2 years ago • 5 comments

Helm charts are not in a good state right now as they are a bit disconnected from the kustomize resources.

We should align the definitions and make the charts a part of the release.

regadas avatar Apr 18 '22 11:04 regadas

Can you show me where the kustomize resources are? currently trying to use the helm chart, if you are telling me that the helm chart is critically wrong, then I would like to understand the best place to install from

saminahbab avatar May 11 '22 22:05 saminahbab

Hi @saminahbab the kustomize resources are available under releases https://github.com/spotify/flink-on-k8s-operator/releases/download/v0.4.0/flink-operator.yaml

regadas avatar May 12 '22 06:05 regadas

Also I would like to mention, Helm charts are using gen-cert.yaml which generates secret by openssl instead of relying on cert-manager (just like kustomization way does) It should be reworked as well as it doesn't work right now:

"creationTimestamp":<nil> "name":"webhook-server-cert" "namespace":"flink-operator-system"]]}
from server for: "STDIN": secrets "webhook-server-cert" is forbidden: User "system:serviceaccount:flink-operator-system:flink-sa" cannot get resource "secrets" in API group "" in the namespace "flink-operator-system"

In logs on cert-job job

Sudokamikaze avatar Jun 16 '22 20:06 Sudokamikaze

Is there any further progress? I have same problem still.

heumsi avatar Aug 10 '22 01:08 heumsi

I try to fix it #460

jiamin13579 avatar Sep 01 '22 03:09 jiamin13579

Tried to address by updating the existing script - #500.

nickcaballero avatar Oct 22 '22 15:10 nickcaballero

Given that the update_template.sh is now sourcing directly from the Kustomize output, is the next step here to somehow incorporate the Helm chart updates as part of new releases?

nickcaballero avatar Oct 26 '22 19:10 nickcaballero

@nickcaballero short answer to that is yes! :)

regadas avatar Oct 27 '22 11:10 regadas