ffwd icon indicating copy to clipboard operation
ffwd copied to clipboard

ffwd version should be added as a tag on a metric

Open dmichel1 opened this issue 4 years ago • 3 comments

That way the version can be monitored when doing a deploy.

dmichel1 avatar Feb 27 '20 21:02 dmichel1

Should it be a resource identifier to prevent disappearing metrics in Heroic?

hexedpackets avatar Feb 27 '20 22:02 hexedpackets

I was actually assuming this would be a what = ffwd-version w/ some value emitted (in the $key = ffwd-java). not some tag appended to everything. That way we can query for that and use say count(what,) groupBy to measure rollouts.

sjoeboo avatar Feb 27 '20 22:02 sjoeboo

We could measure rollouts that way, but not compare metrics across versions - eg that wouldn't show the UDP issue from #191. So I guess what's our goal with the version tag? Measure rollout progress or watch for performance regressions?

hexedpackets avatar Feb 27 '20 23:02 hexedpackets