dockerfile-maven icon indicating copy to clipboard operation
dockerfile-maven copied to clipboard

create a test that fails to demonstrate issue #75

Open ryangardner opened this issue 7 years ago • 2 comments

Note: in its current form, this test fails... I haven't worked on a fix for it, but figured an IT that failed might make it easier to fix the issue reported in #75

ryangardner avatar Oct 03 '17 17:10 ryangardner

Hmm... nevermind. this test doesn't demonstrate this issue yet. I'll try to improve it so it does.

ryangardner avatar Oct 03 '17 17:10 ryangardner

This latest PR also adds a simple fix for the issue identified... the test metadata method tries to copy everything from the docker info directory over - if that directory is used for something else and has folders in it, the copy will fail.

It seems like only copying the set of expected files over would be a better behavior, because it's hard to detect if someone is putting files in that directory that shouldn't be there - but if there is a directory there in this PR it will be detected and a suggestion on how to configure the plugin will be logged at the warning level

ryangardner avatar Oct 03 '17 17:10 ryangardner