dockerfile-maven icon indicating copy to clipboard operation
dockerfile-maven copied to clipboard

* Add arbitrary build param support

Open DylanSchell opened this issue 6 years ago • 8 comments

For some builds, we need shm-size support. by implementing arbitrary build parameter support, it should be possible to just configure

1000000000

DylanSchell avatar May 14 '18 08:05 DylanSchell

Any update on this PR?

cagdascirit avatar Jul 18 '18 10:07 cagdascirit

Merging this PR should solve #202 as well.

steven-sheehy avatar Jul 31 '18 15:07 steven-sheehy

fixed the typo

DylanSchell avatar Aug 01 '18 08:08 DylanSchell

Hi @DylanSchell, @steven-sheehy I have actually an issue where I need to add build param to docker CLI to fix it. Can I help on this PR in order to release this new feature quickly ?

fabballe avatar Dec 19 '18 14:12 fabballe

Any chance this can get the conflict fixed and merged? I am really needing this to set build arguments like network=host

realn0whereman avatar Aug 23 '19 15:08 realn0whereman

We use intermediate containers to save space. This option would help a lot for CI builds. I could use --force-rm without having to support my own version of the plugin.

ktor avatar Jun 03 '20 01:06 ktor

I could really do with this PR... I need to add some options to docker build command...

sergiowww avatar Mar 22 '22 01:03 sergiowww

Can't you just build the whole file from scratch?

On Tue, Mar 22, 2022 at 4:19 AM Sergio Eduardo Dantas de Oliveira < @.***> wrote:

I could really do with this PR... I need to add some options to docker build command...

— Reply to this email directly, view it on GitHub https://github.com/spotify/dockerfile-maven/pull/174#issuecomment-1074584824, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUTIGD6X7SSGDW3C2OBDWBLVBENZ5ANCNFSM4E7VRENA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

windows10hater avatar Mar 22 '22 13:03 windows10hater