docker-client icon indicating copy to clipboard operation
docker-client copied to clipboard

Stop using Guava's immutable collection types in public getters?

Open davidxia opened this issue 8 years ago • 2 comments

This library can cause issues for projects that use its shaded jar and a different version of guava. Should we make a breaking change and stop using Guava's immutable collection types in public getters?

See https://github.com/spotify/helios/issues/1142

davidxia avatar Nov 16 '17 18:11 davidxia

I know that when the abstract getters return Immutable* collection types, AutoValue will generate implementations that also use the Immutable* types. Do you know what collection types AutoValue will generate if your abstract getters do not return the Immutable* types?

I don't know if this matters.

johnflavin avatar Nov 20 '17 13:11 johnflavin

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 24 '18 14:09 stale[bot]