dbeam icon indicating copy to clipboard operation
dbeam copied to clipboard

Published 20 hours ago • verified publisher icon spotify

Add failing tests for reading just produced output avro files.

Open rulle-io opened this issue 2 years ago • 0 comments

Print user-provided Avro schema to a log.

Unit-tests to illustrate existing issues when incorrect user-supplied Avro schema is used. #579

Testing

  • "Unit tests are included"

Checklist for PR author(s)

  • [x] Changes are covered by unit tests (no major decrease in code coverage %) and/or integration tests.
  • [x] Ensure code formating (use mvn com.coveo:fmt-maven-plugin:format org.codehaus.mojo:license-maven-plugin:update-file-header)
  • [x] Document any relevant additions/changes in the appropriate spot in javadocs/docs/README.

rulle-io avatar Feb 06 '23 22:02 rulle-io

@deepakn94 , could you help review?

ericharper avatar Apr 17 '24 21:04 ericharper

Hi @acphile , thanks so much for the PR! I believe we implemented something similar in parallel: https://github.com/NVIDIA/Megatron-LM/commit/e69187bc3679ea5841030a165d587bb48b56ee77. Let me know if you think otherwise!

deepakn94 avatar Apr 17 '24 21:04 deepakn94

OK. Thank you for letting me know this commit. Yes, I think the intention is the same

acphile avatar Apr 18 '24 19:04 acphile

Marking as stale. No activity in 60 days.

github-actions[bot] avatar Jun 18 '24 18:06 github-actions[bot]