dbeam icon indicating copy to clipboard operation
dbeam copied to clipboard

Published 20 hours ago • verified publisher icon spotify

WIP. Support Amazon S3 FileSystem.

Open rulle-io opened this issue 4 years ago • 9 comments

Requires more testing. Works locally in IDEA. Related to #209 .

rulle-io avatar Jun 08 '20 15:06 rulle-io

why did we not merge this pr?

xuanpan avatar Jun 11 '20 07:06 xuanpan

I have not managed to make integration tests to work (in time). Will continue working on this during next available timeslot. ;)

rulle-io avatar Jun 14 '20 21:06 rulle-io

understand. understand. Looking forward to it. Is it during a hack day interval? We'd like to understand if we can have it out in our next release cycle.

xuanpan avatar Jun 14 '20 21:06 xuanpan

first of all, thanks for the patch: dbeam is used in production with S3 targets at one of my large client. Is there anything I can help with to get it merged? adding tests or docuemtation? thx /cc @rulle-io

tfoldi avatar Sep 08 '20 09:09 tfoldi

Sorry, I got involved in other things and forgot about it. :) I will create a proper PR in coming days. Technically, I wanted to add a e2e test to see that iy actually works. If you can add such one, it would simplify things a lot. @tfoldi

rulle-io avatar Sep 08 '20 10:09 rulle-io

I also forgot about this. You rock Ruslan. Looking forward to include this in our next release

xuanpan avatar Sep 08 '20 10:09 xuanpan

Technically, I wanted to add a e2e test to see that iy actually works. If you can add such one, it would simplify things a lot. @tfoldi

I can do the e2e tests, no issues. Do we want to use a real S3 bucket or just a mocked S3 service? If you want the real thing, we might need to set up access/secret keys for the CI.

tfoldi avatar Sep 10 '20 04:09 tfoldi

Just a mocked S3 service, please.

rulle-io avatar Sep 10 '20 15:09 rulle-io

How about this: https://github.com/rulle-io/dbeam/pull/1/commits/6647bb84e1dd9362ed9e2542ac496cc93ac53eb9 ?

tfoldi avatar Sep 11 '20 10:09 tfoldi