Fix simple OCLint warnings

[dflems]

OCLint is another static analysis tool that focuses on reducing complexity, confusion, and redundant code. It has a ton of rules. This PR knocks out some of the simpler ones.

The tool also handles analyzing cyclomatic complexity and npath complexity, which could help identify places that could probably use a refactor or reduction in complexity.

Many of the rules are conventional but could also be useful (method length, line length, class length, etc.)

[spotify-ci-bot]

	3 Messages
:book:	Executed 385 tests, with 0 failures (0 unexpected) in 6.809 (7.352) seconds
:book:	Executed 381 tests, with 0 failures (0 unexpected) in 6.306 (6.780) seconds
:book:	Executed 11 tests, with 0 failures (0 unexpected) in 217.134 (217.143) seconds

Generated by :no_entry_sign: Danger

[codecov-io]

Codecov Report

Merging #337 into master will increase coverage by 0.07%. The diff coverage is 90.21%.

@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
+ Coverage   80.08%   80.16%   +0.07%     
==========================================
  Files          84       84              
  Lines        4510     4496      -14     
==========================================
- Hits         3612     3604       -8     
+ Misses        898      892       -6

Impacted Files	Coverage Δ
...rces/HUBViewControllerExperimentalImplementation.m	5.27% <0%> (+0.01%)	:arrow_up:
sources/HUBAutoEquatable.m	100% <100%> (ø)	:arrow_up:
sources/HUBViewModelRenderer.m	95.38% <100%> (ø)	:arrow_up:
sources/HUBComponentWrapper.m	71.42% <100%> (-0.12%)	:arrow_down:
sources/HUBLiveServiceFactory.m	100% <100%> (+25%)	:arrow_up:
sources/HUBViewControllerFactoryImplementation.m	100% <100%> (ø)	:arrow_up:
sources/HUBViewControllerImplementation.m	88.37% <100%> (-0.04%)	:arrow_down:
sources/HUBViewModelDiff.m	96.4% <100%> (-0.05%)	:arrow_down:
sources/HUBDefaultConnectivityStateResolver.m	72.54% <100%> (-0.53%)	:arrow_down:
sources/HUBComponentModelBuilderImplementation.m	96.75% <100%> (ø)	:arrow_up:
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ebdb44...56404ca. Read the comment docs.