HubFramework icon indicating copy to clipboard operation
HubFramework copied to clipboard

Alternative to https://github.com/spotify/HubFramework/pull/283

Open marmelroy opened this issue 8 years ago • 4 comments

Traversing the view hierarchy in search of specific class that handle touches is not really scalable.

This is an alternative solution.

marmelroy avatar Feb 15 '17 06:02 marmelroy

2 Errors
:no_entry_sign: HubFrameworkDemoUITests.ReloadUITests: testReloadingContent, UI Testing Failure - Neither element nor any descendant has keyboard focus. Element:
ReloadUITests.swift#L51
:no_entry_sign: Tests have failed, see below for more information.
3 Messages
:book: Executed 343 tests, with 0 failures (0 unexpected) in 7.452 (8.802) seconds
:book: Executed 340 tests, with 0 failures (0 unexpected) in 7.204 (8.524) seconds
:book: Executed 9 tests, with 1 failure (0 unexpected) in 140.900 (140.918) seconds

Tests:

Classname Name Time
ReloadUITests testReloadingContent() 25.472521007061005

Generated by :no_entry_sign: danger

spotify-ci-bot avatar Feb 15 '17 07:02 spotify-ci-bot

@mumme @marmelroy I prefer this solution a lot to what Hub framework does and what was added in #283! Seems like a better way to do it.

rastersize avatar Feb 15 '17 12:02 rastersize

This solution did not work for the segmented control case.

mumme avatar Feb 15 '17 13:02 mumme

@mumme, did a little investigation and it appears that the reason this doesn't work is that UISegementedControl doesn't implement any gesture recognisers and captures touches directly (thanks Apple).

marmelroy avatar Feb 19 '17 14:02 marmelroy