cryptocurrency-icons icon indicating copy to clipboard operation
cryptocurrency-icons copied to clipboard

ETH Logo is off centre

Open ricburton opened this issue 2 years ago • 8 comments

CleanShot 2022-03-08 at 11 51 28@2x

ricburton avatar Mar 08 '22 19:03 ricburton

CleanShot 2022-03-08 at 12 00 41@2x

ricburton avatar Mar 08 '22 20:03 ricburton

Hello @ricburton, thanks for the feedback. I did not design this icon initially, but I took the time to review it carefully. I think this is intended. But the applied offset is however a little bit off.

I tried the example you have shown and it is off-centered as well (to the left this time). Given the alpha blending asymmetry, the icon needs to be offset to the right in order to correctly distribute its mass. That is easier to see when the icon is small: I'm always doing optical centering by reducing the size dramatically.

Applying an offset of .75 (instead of 1 currently) seems correct in this case (in short, if I had to put an integer I would have chosen 1 like the original).

ETH

Please take a look and tell me if that makes sense to you.

I can see in your example that you reduced the size of the icon as well. Maybe we can settle it this way: a smaller icon, with .75 — let me know what you think.

tommdn avatar Mar 08 '22 22:03 tommdn

I have not given an example SVG yet :)

Want me to export and send over?

Glad to see the project accepts contributions.

ricburton avatar Mar 08 '22 22:03 ricburton

image

You need to slightly scale the ETH logo up by a pixel.

ricburton avatar Mar 08 '22 22:03 ricburton

I have not given an example SVG yet :)

I was talking about the image you have uploaded with on the left side the current state of the ETH icon, on the right side your version which is horizontally centered (and with a smaller icon size). Seems to be the "Scaled down" version from the second image. Isn't it?

Glad to see the project accepts contributions.

Well, as mentioned in the README, the previous contributors added the part saying pull requests are not accepted. Mainly because it takes more time to fix an icon than to make it. But I'm pleased to see suggestions like yours — those are always welcome.

I'm not sure I totally understand the image you have just uploaded here. There are three different topics.

  • First, what aspect ratio we choose. If the aspect ratio is not conform to the Ethereum branding one, then the one who made the icon did a mistake and we indeed need to change it.
  • Next, regarding the size in the circle I understand you would prefer the icon to be larger in the circle. I'm not opposed to it but it should look harmonious with the other icons (for example ADX has a comparable surface).
  • Regardless of the aspect ratio or icon size, the point of my first answer was that the icon should not be horizontally centered. One of the main value of this repository is optical centering and this is in most cases not pure horizontal or vertical centering.

Please give me answers on each of those three points so we can break down the problem.

tommdn avatar Mar 08 '22 23:03 tommdn

Here you go eth !

I can compress it too if that helps. But this is perfectly in the middle.

ricburton avatar Mar 09 '22 00:03 ricburton

Slice Explaining the thinking more.

ETH is the most popular asset

ricburton avatar Mar 09 '22 00:03 ricburton

I think the the offset is intentional because of the pixel distribution of small sizes. Having even numbers (16px, 24px) you do not have a center pixel which would make an edge exactly on the center more blurry due to interpolation. So, by applying an offset the edge starts getting more pronounced on one of the sides and thus looks sharper even on really small sizes.

With offset: Bildschirmfoto von 2022-03-09 08-56-03

Your centered version: Bildschirmfoto von 2022-03-09 08-57-16

syeo66 avatar Mar 09 '22 06:03 syeo66