redis-operator icon indicating copy to clipboard operation
redis-operator copied to clipboard

Published 20 hours ago • verified publisher icon spotahome

fix: fixed issue mentioned in https://github.com/spotahome/redis-oper…

Open EsDmitrii opened this issue 1 year ago • 8 comments

Fixed issue mentioned in https://github.com/spotahome/redis-operator/pull/631

EsDmitrii avatar Jan 19 '24 11:01 EsDmitrii

Also getting the error, identified by @liupeng0518 at https://github.com/spotahome/redis-operator/pull/631#issuecomment-1833309651 Re: this open issue https://github.com/spotahome/redis-operator/issues/679

helm install redis-operator redis-operator/redis-operator
Error: INSTALLATION FAILED: failed to install CRD crds/databases.spotahome.com_redisfailovers.yaml: error parsing : error converting YAML to JSON: yaml: line 4: did not find expected node content

Believe this PR will fix the above error. Any update on this being reviewed/merged? cc: @EsDmitrii @ese

Thanks so much.

tpmccallum avatar Jan 22 '24 01:01 tpmccallum

Also getting the error, identified by @liupeng0518 at #631 (comment) Re: this open issue #679

helm install redis-operator redis-operator/redis-operator
Error: INSTALLATION FAILED: failed to install CRD crds/databases.spotahome.com_redisfailovers.yaml: error parsing : error converting YAML to JSON: yaml: line 4: did not find expected node content

Believe this PR will fix the above error. Any update on this being reviewed/merged? cc: @EsDmitrii @ese

Thanks so much.

Hi! Yep I used helm tempting for CRD and it was outside folder for templates so when you try to deploy helm says “dude I don’t know what is it, it’s not a crd” :) It should fix the issue

EsDmitrii avatar Jan 25 '24 18:01 EsDmitrii

@EsDmitrii is this ready to merge? I would really like to use your CRD changes for disablePodDisruptionBudget

winterrobert avatar Feb 19 '24 10:02 winterrobert

@winterrobert Hi! I have no write access to this repo to merge chages

EsDmitrii avatar Feb 19 '24 10:02 EsDmitrii

@ese Hi! Can you review changes and merge this PR please? It's blocking users

EsDmitrii avatar Feb 19 '24 10:02 EsDmitrii

@EsDmitrii I am facing the same issue in argocd, but will this fix the issue? Because you are using template language in yaml which is in crds folder, helm template would not be able to process it.

anantha1999 avatar Mar 07 '24 09:03 anantha1999

@EsDmitrii I am facing the same issue in argocd, but will this fix the issue? Because you are using template language in yaml which is in crds folder, helm template would not be able to process it.

Yes, it will. Folder with crd located in template folder. You can pull changes and test it locally

EsDmitrii avatar Mar 12 '24 12:03 EsDmitrii