redis-operator
redis-operator copied to clipboard
Add support for creating PodMonitor or ServiceMonitor
Expected behaviour
Create PodMonitor/ServiceMonitor object for Redis and Sentinel.
Actual behaviour
Prometheus exporters are integrated into the RedisFailover CRD, but they still require PodMonitors or ServiceMonitors.
Proposed solution
Allow creating PodMonitor or ServiceMonitor resources along with exporters. For example:
apiVersion: databases.spotahome.com/v1
kind: RedisFailover
metadata:
name: redis
spec:
redis:
exporter:
enabled: true
monitoring:
podMonitor:
enabled: true
sentinel:
exporter:
enabled: true
monitoring:
podMonitor:
enabled: true
Additional details
I'd be happy to draft a PR if you like the idea.
This issue is stale because it has been open for 45 days with no activity.
Not stale
This issue is stale because it has been open for 45 days with no activity.
Bump
This issue is stale because it has been open for 45 days with no activity.
bump
It would be great count with the feature if you want to make a PR :) @sagikazarmark
This was closed by error, I'd say. @ese this feature request is regarding ServiceMonitors on the pods managed by the operator, not for the operator itself.
Indeed, I added it to the referenced PR by accident.
Resubmitted the issue, since I can't reopen it. I'll send a PR when I get there.