redis-operator icon indicating copy to clipboard operation
redis-operator copied to clipboard

Add support for creating PodMonitor or ServiceMonitor

Open sagikazarmark opened this issue 2 years ago • 6 comments

Expected behaviour

Create PodMonitor/ServiceMonitor object for Redis and Sentinel.

Actual behaviour

Prometheus exporters are integrated into the RedisFailover CRD, but they still require PodMonitors or ServiceMonitors.

Proposed solution

Allow creating PodMonitor or ServiceMonitor resources along with exporters. For example:

apiVersion: databases.spotahome.com/v1
kind: RedisFailover
metadata:
  name: redis
spec:
  redis:
    exporter:
      enabled: true
    monitoring:
      podMonitor:
          enabled: true
  sentinel:
    exporter:
      enabled: true
    monitoring:
      podMonitor:
          enabled: true

Additional details

I'd be happy to draft a PR if you like the idea.

sagikazarmark avatar Mar 02 '22 20:03 sagikazarmark

This issue is stale because it has been open for 45 days with no activity.

github-actions[bot] avatar Apr 17 '22 02:04 github-actions[bot]

Not stale

sagikazarmark avatar Apr 19 '22 02:04 sagikazarmark

This issue is stale because it has been open for 45 days with no activity.

github-actions[bot] avatar Jun 05 '22 02:06 github-actions[bot]

Bump

sagikazarmark avatar Jun 06 '22 03:06 sagikazarmark

This issue is stale because it has been open for 45 days with no activity.

github-actions[bot] avatar Jul 22 '22 02:07 github-actions[bot]

bump

sagikazarmark avatar Jul 24 '22 22:07 sagikazarmark

It would be great count with the feature if you want to make a PR :) @sagikazarmark

ese avatar Sep 05 '22 13:09 ese

This was closed by error, I'd say. @ese this feature request is regarding ServiceMonitors on the pods managed by the operator, not for the operator itself.

Wouter0100 avatar Oct 03 '22 22:10 Wouter0100

Indeed, I added it to the referenced PR by accident.

sagikazarmark avatar Oct 03 '22 22:10 sagikazarmark

Resubmitted the issue, since I can't reopen it. I'll send a PR when I get there.

sagikazarmark avatar Oct 04 '22 14:10 sagikazarmark