Update downloader.py
Set default fallback audio bitrate when no abr (assume available Bir rate) is found or null. from else "copy" => else "320k"
Title
Missing fallback bitrate
Description
ffmpeg was failing when no bitrate was sent it was receiving "copy" vs bitrate and ffmpeg needs -c for copy. changed else to fall back to 320k
Related Issue
#2364
Motivation and Context
ffmpeg will not make output file as script doesnt have fallback bitrate
How Has This Been Tested?
cli python3
Types of Changes
- [x ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist
- [ x] My code follows the code style of this project
- [ ] My change requires a change to the documentation
- [ ] I have updated the documentation accordingly
- [ ] I have read the CONTRIBUTING document
- [x ] I have read the CORE VALUES document
- [ ] I have added tests to cover my changes
- [ x] All new and existing tests passed
I have the same issue and can confirm the fix is working, so pulling this would be much appreciated :)
If falling back to 320k when there's no 320k available, wouldn't that just result in a larger file size without the increase in quality?
Dropped in favour of 4534cdc8a0804d53dd76ebc2acc58e74fc71cb0a