spotify-downloader icon indicating copy to clipboard operation
spotify-downloader copied to clipboard

Add lyrics sync as a console operation

Open fer-hnndz opened this issue 2 years ago • 6 comments

Lyrics Sync Console Operation

Description

This pull requests adds an operation that allows to sync lyrics with already downloaded song files. Usage spotdl lyrics {path}

Related Issue

#1589

Motivation and Context

Lots of people (including me) have experienced that some songs are downloaded with its metadata, but without their corresponding lyrics. This feature solves this issue.

How Has This Been Tested?

Running the operation from the console, testing with a copy of my own music library.

Screenshots (if appropriate)

Types of Changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [x] My code follows the code style of this project
  • [x] My change requires a change to the documentation
  • [ ] I have updated the documentation accordingly
  • [x] I have read the CONTRIBUTING document
  • [x] I have read the CORE VALUES document
  • [ ] I have added tests to cover my changes
  • [ ] All new and existing tests passed](url)

fer-hnndz avatar Sep 14 '22 01:09 fer-hnndz

I'm still trying to fix those lint issues, however I don't know how I could solve those issues where the lines are larger than a 100 characters. Since those are messages for the user, should i try to make them smaller in some way?

fer-hnndz avatar Sep 14 '22 16:09 fer-hnndz

While I was testing, all providers were returning None, I checked my code and I didn't find any errors. Are we being rate-limited or something?

I'll keep testing and checking my code to find any issues.

fer-hnndz avatar Sep 15 '22 17:09 fer-hnndz

Maybe instead of embedding only lyrics we could search spotify based on the file's name and apply and apply all the metadata if it doesn't have any. And if the file has metadata but it doesn't have the lyrics we could try getting the lyrics.

xnetcat avatar Sep 18 '22 09:09 xnetcat

Maybe instead of embedding only lyrics we could search spotify based on the file's name and apply and apply all the metadata if it doesn't have any. And if the file has metadata but it doesn't have the lyrics we could try getting the lyrics.

Should I try to get the name and artists from the filename or should I prompt the user to enter the information?

I imagine a case where the song file is not as artist - song_name

fer-hnndz avatar Sep 19 '22 00:09 fer-hnndz

Maybe instead of embedding only lyrics we could search spotify based on the file's name and apply and apply all the metadata if it doesn't have any. And if the file has metadata but it doesn't have the lyrics we could try getting the lyrics.

Should I try to get the name and artists from the filename or should I prompt the user to enter the information?

I imagine a case where the song file is not as artist - song_name

Spotify should handle such results, but for the best measure we can compare both strings (file name and song.title)

xnetcat avatar Sep 19 '22 06:09 xnetcat

I only tested this with a mp3 that i downloaded from youtube with no metadata. Not sure how to get the rest of file extensions without metadata to try them out

fer-hnndz avatar Sep 21 '22 03:09 fer-hnndz