wehoop
wehoop copied to clipboard
text_type in load_wbb_pbp has MadeFreeThrow for both made and missed free throws
Describe the bug The column text_type in the resulting data from load_wbb_pbp() has "MadeFreeThrow" for both made and missed free throws
To Reproduce Steps to reproduce the behavior:
- Call load_wbb_pbp()
- Filter by text to retrieve missed free throws
- text for "[Name] missed Free Throw" has "MadeFreeThrow" for the value of text_type
Expected behavior The text should be either "FreeThrow" or "MissedFreeThrow" for more intuitive filtering.
Screenshots If applicable, add screenshots to help explain your problem.

Version: 1.2.1
Additional context Encountered while trying to calculate Athletes Unlimited Scoring from Play-by-Play
While not something I mess with to create the type_text field, nonetheless disconcerting. I will try to validate more as the season goes along (more like off-season) , but if you have like code to validate the types, I'd welcome a PR