Jim Newsome
Jim Newsome
> Hard-code the shim not to use native thread local storage even if it appears to be available. I *think* this is the only part not fixed now at HEAD....
I got the tor-minimal test working again with this @ shadow's head. The changes needed: * Set the shim's thread local storage mode to `tls::Mode::NativeTlsId`. We ought to add a...
> I think this seems nicer than redirecting the stdout/stderr of all managed processes to shadow's stdout/stderr. To be clear I wasn't proposing that - I was proposing that the...
> To be clear I wasn't proposing that - I was proposing that the native stdout and stderr go to the process's "managed" stdout and stderr files respectively instead of...
> An option to limit the number of files/descriptors could be to use a Unix socket. I believe that you can use recvmsg to get the pid of the sender...
Interesting; maybe it'd be worth doing that for the shim log too; i.e. get rid of the separate shim log files and pipe them through shadow's logging instead.
The `address/get_if_addrs_ioctl` failure probably corresponds to shadow's warning about `SIOCGIFCONF` being unimplemented. This wouldn't be too bad to implement, but we could reasonably ignore this failure since tor simulations still...
``` crypto/openssl/rng_engine: [forking] FAIL src/test/test_crypto_openssl.c:29: assert(0 OP_EQ crypto_force_rand_ssleay()): 0 vs 1 [rng_engine FAILED] ``` Here's the `tor` function that's failing, from `src/lib/crypt_ops/crypto_rand.c`: ``` int crypto_force_rand_ssleay(void) { #ifdef ENABLE_OPENSSL RAND_METHOD *default_method;...
``` dir/bwauth_bw_file_digest256: FAIL src/test/test_dir.c:4471: assert(-1 OP_EQ dirserv_read_measured_bandwidths(fname, NULL, NULL, digest)): -1 vs 0 [bwauth_bw_file_digest256 FAILED] ``` This failure comes from `src/test/test_dir.c`: ``` const char *content = "1541171221\n" "node_id=$68A483E05A2ABDCA6DA5A3EF8DB5177638A27F80 " "master_key_ed25519=YaqV4vbvPYKucElk297eVdNArDz9HtIwUoIeo0+cVIpQ...
``` dir_handle_get/server_descriptors_all: [forking] FAIL src/test/test_dir_handle_get.c:633: assert(body_used OP_EQ mock_routerinfo->cache_info.signed_descriptor_len): 18238 vs 2306 [server_descriptors_all FAILED] ``` This one's interesting. Here's the code: ``` //TODO: Is this a BUG? //It requires strlen(signed_descriptor_len)+1 as...