Allow Byrna/bomb kills on 'easy' enemy health

[super-aardvark]

Settings

Enemy Health: easy

---

Description of problem:

In ItemCollection functions canKillEscapeThings and canKillMostThings, Byrna or bombs are sufficient only if enemy health is 'default'. It seems to me they should also be sufficient on 'easy' enemy health. (Doc says with 'easy' everything dies in 1-2 fighter sword slashes, and blue guards in escape require 3 fighter sword slashes on 'default'.)

[MarcyAugust]

Unless I'm mistaken, shouldn't that be as simple as adding another or statement to those functions?

Like this: ($this->has('CaneOfByrna') && $world->config('enemizer.enemyHealth', 'default') == 'default') || $world->config('enemizer.enemyHealth') == 'easy'). Not sure if the ",'default' that's present in the first enemyHealth would also be needed though.

Edit: As far as I can tell looking at damage values and enemy health in easy, byrna should at max only need to hit 3 times to kill nearly everything in easy? With the new logic coming in, potentially it could be viable as a weapon in escape then if magic is made infinite until the zelda escort is finished.

[sporchia]

For the moment we are going to pass on this, we have been working to merge the enemizer into the main code base in v32, in which case we will be able to specifically assure enough dmg can be done with the tools at hand. Thank you for the feedback.