alttp_vt_randomizer
alttp_vt_randomizer copied to clipboard
Multi-location hints (left side swamp, pyramid fairy, etc.) aren't being generated
Item, Entrance or Custom: Item Enemizer Options: None
Description of problem: In v31, hint generation for multi-location hints isn't working as expected. Whenever HintService::applyHints chooses a "bad" location that's an array, the hint fails to generate and instead more progression/random/joke hints end up being generated to take the resulting extra places.
The root cause is that the function being passed to filter is comparing the location's multiworld name with the ID appended, to the non-multiworld name listed in the $locations array at the top of the function, resulting in no matches and an empty LocationCollection. Similar issues arise in LocationCollection::getHint when looking up the item and location text in the hint translation file.
Finally, some of the location description standardization added alternate generic descriptions for these locations in the hint translation file, but placed them at the beginning causing the multi-location hints to always select the generic description, despite the multiple locations making it obvious which specific locations it refers to.
Steps to reproduce: Generate some seeds from the command line with hints enabled and logging set to the debug level. grep -i
the laravel log for " and "
to find instances of multiple location hints being generated, and note that none are being generated.