spoorn
Merge Starlight
Starlight is already available for Forge though, it's just not on CurseForge. If we merge in Starlight, it should be under the Starlight owner's wish as we'll have to keep maintaining it for any bugs or issues. Why doesn't Starlight publish to CurseForge themselves?
If we merge in Starlight and it splits development with the original Starlight, then the 2 will become incompatible
Well Phosphor and Starlight obviously can't be run together so I've no idea what to do with this tbh.
Or maybe a config option to switch between the two? It's possible with a custom mixin connector which decides which mixins to apply.
I meant Starlight will keep updating, so if we merge it into here we'd have to maintain it. And then Sodium won't be compatible with Starlight if it ever gets added to Curseforge itself or if players add it manually - so I don't think we should merge Starlight into the release branch. If anything, it should stay in a separate branch
Hm, @spoorn alternate idea. How about detecting if Starlight is installed, and if yes, disabling Phosphor inside the mod? That way we won't have to include it ourselves.
Do you mean disabling Starlight in the mod? Starlight features in Sodium is nice, but I don't have the time to maintain it :P
Also, the Starlight author seems to be purposely not releasing on CurseForge while they continue development (https://github.com/Tuinity/Starlight/issues/21, https://github.com/Tuinity/Starlight/issues/65), so I don't want to release it on CurseForge without their permission.
If they don't want Starlight on CurseForge, we can still have a starlight branch on github
No, I didn't mean that. The idea is not merging this, and if Starlight is loaded (from the outside) disable Phosphor-related features in here. That way it should be compatible. Or is this a stupid idea?