node-shell icon indicating copy to clipboard operation
node-shell copied to clipboard

Implemented most of the BrowserWindow api accessors. Extended the wrappe...

Open miketheprogrammer opened this issue 11 years ago • 3 comments

...r dnode to allow for passing results back through callbacks, as well as events

Accept it if you like it, just felt this was a nice way to help out for now. I return "this" from each funtion since you were starting to do method chaining and assignment but it actually didnt work because no this was returned.

There is an options.strictApi for throwing errors on function that return a value, throw error if now callback.

Pretty simple just alot of typing heh.

miketheprogrammer avatar Jul 19 '14 22:07 miketheprogrammer

also added common.noop. Its an optimization. Allows the v8 optimizing compiler to use 1 function and optimize it, rather than generating a new function on every call.

miketheprogrammer avatar Jul 19 '14 22:07 miketheprogrammer

hey @spolu can you review this pr? :)

junosuarez avatar Aug 23 '14 18:08 junosuarez

@jden work on this repository is deprecated and has moved to this: https://github.com/breach/exo_browser/issues/161 https://github.com/breach/exo_browser/tree/wip-0.7

spolu avatar Aug 24 '14 10:08 spolu