Miro Spönemann

Results 306 comments of Miro Spönemann

Cancellation is now supported (#238), so what's left to do here is progress reporting.

The good thing about `getDocument(astNode)` is that it's very clear and no magic involved. Using prototypes would increase the API surface of the AST, so it would no longer be...

This won't be necessary after doing #440.

Actually we still need to add the editor features mentioned above for property assignments in case the assigned property is declared in an `interface`.

Fixed with https://github.com/langium/langium/pull/505

> Should supporting renaming of a package e.g. complex also be a part of this issue? Ideally yes (needs special handling to rename all references to contained classes). > What...

?? I can still reproduce following the steps described at the top.

Related: gradle/gradle#898 What workaround could be applied until this is solved?

We could move the initialization code to a static initializer block? Then it's executed as soon as the class is loaded.

The ElkReflect initialization code for any IDataObject should be written in a static initializer of that class, then you're 100% sure it's executed before you use any instance of it....