spock icon indicating copy to clipboard operation
spock copied to clipboard

Test explicit and implicit call() invocations for pollling conditions

Open Vampire opened this issue 6 months ago • 2 comments

Vampire avatar Jun 03 '25 15:06 Vampire

This stack of pull requests is managed by Graphite. Learn more about stacking.

Vampire avatar Jun 03 '25 15:06 Vampire

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 82.07%. Comparing base (3013685) to head (c98ef35). :warning: Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2172      +/-   ##
============================================
+ Coverage     82.04%   82.07%   +0.02%     
  Complexity     4754     4754              
============================================
  Files           465      465              
  Lines         14871    14871              
  Branches       1878     1878              
============================================
+ Hits          12201    12205       +4     
+ Misses         1982     1978       -4     
  Partials        688      688              

see 1 file with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 03 '25 15:06 codecov[bot]

@Vampire Did you maybe forgot to push your changes?

AndreasTu avatar Oct 25 '25 07:10 AndreasTu

Forgot to push? No Already pushed? No Requested Re review? No :-)

I tried to re-understand "see PollingConditions javadoc." to know what the problem is, maybe describe it more explicitly, and evaluate whether it needs to be added to all such lines and not only those where you suggested it, then I had to go.

Vampire avatar Oct 25 '25 10:10 Vampire

Merge activity

  • Oct 28, 4:30 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Oct 28, 4:31 PM UTC: Graphite rebased this pull request as part of a merge.
  • Oct 28, 4:53 PM UTC: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Build and Verify (5.0, 25, ubuntu-latest)').

Vampire avatar Oct 28 '25 16:10 Vampire