spock icon indicating copy to clipboard operation
spock copied to clipboard

JDK 22 CI build

Open szpak opened this issue 10 months ago • 4 comments

This PR adds JDK 22 CI build.

I don't see a good reason to build with both 21 LTS and 22, so the former is replaced by the later.

As a bonus, I also improved the visibility in GitHub Actions UI, the order of matrix variables has been changed (I might move it to a separate PR, if desired).

Before (JDK version and Groovy variant are not visible in the failing builds): image

After: Screenshot from 2024-03-24 20-33-43

szpak avatar Mar 24 '24 19:03 szpak

@leonard84 It seems you need to click somewhere in the project settings to choose the new "mandatory checks".

szpak avatar Mar 24 '24 20:03 szpak

It seems you need to click somewhere in the project settings to choose the new "mandatory checks".

After it was decided to merge the PR, yep. Otherwise all other PRs will miss required checks until this eventually got merged maybe. But don't worry, he can merge the PR even with the required checks missing due to the rename. :-)

I don't see a good reason to build with both 21 LTS and 22, so the former is replaced by the later.

Well, 21 is LTS 22 is latest. Imho that might well be reason enough to build for both.

Vampire avatar Mar 24 '24 21:03 Vampire

After it was decided to merge the PR, yep. Otherwise all other PRs will miss required checks until this eventually got merged maybe.

Sure. That was my intention.

Well, 21 is LTS 22 is latest. Imho that might well be reason enough to build for both.

We have already a large number of builds. Initially, I was thinking about limiting a number of builds with "intermediate" versions. However, in the end, the two extra build (21 with 3.0 and 4.0) would probably not be a big problem.

szpak avatar Mar 24 '24 22:03 szpak

the two extra build (21 with 3.0 and 4.0) would probably not be a big problem.

Sometimes 4 builds - for a push and for a PR (I will start making my branches in my fork).

szpak avatar Mar 24 '24 22:03 szpak

@leonard84 Any more suggestions here?

szpak avatar May 14 '24 18:05 szpak