vault-plugin-secrets-gitlab icon indicating copy to clipboard operation
vault-plugin-secrets-gitlab copied to clipboard

initial version of group access token

Open M0roSan opened this issue 2 years ago • 4 comments

as described in the issue, only adding token_type in BaseTokenStorage and it'll do population.

TODO: switch to create group/project access token based on token_type field

haven't tested with gitlab instance nor vault instance yet

close #36

M0roSan avatar Mar 19 '22 04:03 M0roSan

Codecov Report

Merging #50 (050942e) into main (c9ede88) will decrease coverage by 3.53%. The diff coverage is 22.85%.

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   59.45%   55.92%   -3.54%     
==========================================
  Files          10       10              
  Lines         550      608      +58     
==========================================
+ Hits          327      340      +13     
- Misses        195      240      +45     
  Partials       28       28              
Flag Coverage Δ
unittests 55.92% <22.85%> (-3.54%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugin/gitlab_client.go 25.45% <0.00%> (-11.39%) :arrow_down:
plugin/path_config.go 82.14% <ø> (ø)
plugin/path_token.go 30.13% <5.26%> (-6.53%) :arrow_down:
plugin/path_token_role.go 55.00% <33.33%> (ø)
plugin/token.go 48.71% <44.44%> (-2.27%) :arrow_down:
plugin/path_role.go 75.37% <50.00%> (+0.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c9ede88...050942e. Read the comment docs.

codecov-commenter avatar Mar 19 '22 04:03 codecov-commenter

@nickshine Hi. is this still used and maintained outside here? and also, is it compatible with the running gitlab versions (I don't know which version but based on version compatibility, this should work). I'm more than happy to hand this someone who's actively using and potentially maintaining it

M0roSan avatar Apr 17 '23 23:04 M0roSan

Hey @M0roSan , yep this is still used and compatible with GitLab 15.x. Group access token feature hasn't been implemented b/c nobody has been asking for it, at least not that I've seen.

nickshine avatar Apr 18 '23 02:04 nickshine

I'll take a look at this and see if we can test it out internally (and also update CI).

nickshine avatar Apr 18 '23 02:04 nickshine