splunk-connect-for-syslog icon indicating copy to clipboard operation
splunk-connect-for-syslog copied to clipboard

Feature Request: Use a Secret for HEC Token

Open kurtismullins opened this issue 3 years ago • 3 comments

This is a two-part feature request related to the security of the HEC Token:

  1. The token should be stored in a secret. It can be mounted from the StatefulSet as an environment variable by simply referencing the secret.
  2. Allow referencing your own secret. Storing the token using plain-text in values.yaml and then committing it to a git repository has potential security implications.

If I am overlooking something or there is an obvious work-around, then feel free to share that information and close this issue.

Thanks!

kurtismullins avatar Jan 28 '22 13:01 kurtismullins

Agree will look at this post 2.0

ryanfaircloth avatar Jan 30 '22 15:01 ryanfaircloth

@kurtismullins Work around would be using CI/CD pipeline with the secret as a variable in the pipeline. This way when its deployed the text is replaced, sanitary git repo and yet its auto included in the CD pipeline.

satellite-no avatar Feb 11 '22 23:02 satellite-no

@satellite-no

This may be a valid work-around for some environments, agreed. Thank you for that suggestion!

Unfortunately, we don't have a good place in our pipeline to inject a token from a vault. Even if we did, I would feel much more comfortable storing this token as a Kubernetes Secret than as plain-text within a ConfigMap.

kurtismullins avatar Feb 24 '22 16:02 kurtismullins

:tada: This issue has been resolved in version 2.35.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

srv-rr-github-token avatar Sep 20 '22 09:09 srv-rr-github-token